Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Close the response body of a WriteBatch call #300

Merged
merged 1 commit into from
Jan 13, 2022

Conversation

maxmora
Copy link
Contributor

@maxmora maxmora commented Jan 12, 2022

Proposed Changes

Closes the response body after making a WriteBatch call. Failing to close the response body was keeping OpenCensus spans from being exported when using ochttp.Transport (see: https://github.com/census-instrumentation/opencensus-go/blob/49838f207d61097fc0ebb8aeef306913388376ca/plugin/ochttp/trace.go#L94)

Checklist

  • CHANGELOG.md updated
  • Rebased/mergeable
  • A test has been added if appropriate
  • Tests pass
  • Commit messages are in semantic format
  • Sign CLA (if not already signed)

@maxmora maxmora changed the title Close the response body of a WriteBatch call fix: Close the response body of a WriteBatch call Jan 12, 2022
@maxmora maxmora force-pushed the close-write-batch-body branch from 1039143 to 63bcf73 Compare January 12, 2022 18:47
@codecov-commenter
Copy link

Codecov Report

Merging #300 (63bcf73) into master (ada9e3b) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #300   +/-   ##
=======================================
  Coverage   91.84%   91.84%           
=======================================
  Files          23       23           
  Lines        2036     2036           
=======================================
  Hits         1870     1870           
  Misses        111      111           
  Partials       55       55           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ada9e3b...63bcf73. Read the comment docs.

Copy link
Contributor

@vlastahajek vlastahajek left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix and PR!

@vlastahajek vlastahajek merged commit a00324e into influxdata:master Jan 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants