chore: apply review comments

influxdata · Aug 14, 2020 · 567728f · 567728f
1 parent 82ca912
commit 567728f
Show file tree

Hide file tree

Showing 4 changed files with 10 additions and 9 deletions.
diff --git a/notification/endpoint/endpoint_test.go b/notification/endpoint/endpoint_test.go
@@ -189,7 +189,7 @@ func TestValidEndpoint(t *testing.T) {
 			},
 			err: &influxdb.Error{
 				Code: influxdb.EInvalid,
-				Msg:  "empty teams URL",
+				Msg:  "teams: empty URL",
 			},
 		},
 		{
@@ -325,7 +325,7 @@ func TestJSON(t *testing.T) {
 		},
 		{
 			name: "teams without secretURLSuffix",
-			src: &endpoint.Slack{
+			src: &endpoint.Teams{
 				Base: endpoint.Base{
 					ID:     influxTesting.MustIDBase16Ptr(id1),
 					Name:   "name1",

diff --git a/notification/endpoint/teams.go b/notification/endpoint/teams.go
@@ -46,15 +46,16 @@ func (s Teams) Valid() error {
 	if s.URL == "" {
 		return &influxdb.Error{
 			Code: influxdb.EInvalid,
-			Msg:  "empty teams URL",
+			Msg:  "teams: empty URL",
 		}
 	}
 	return nil
 }
 
+type teamsAlias Teams
+
 // MarshalJSON implement json.Marshaler interface.
 func (s Teams) MarshalJSON() ([]byte, error) {
-	type teamsAlias Teams
 	return json.Marshal(
 		struct {
 			teamsAlias

diff --git a/notification/rule/teams.go b/notification/rule/teams.go
@@ -109,19 +109,19 @@ func (s Teams) Valid() error {
 	if s.Title == "" {
 		return &influxdb.Error{
 			Code: influxdb.EInvalid,
-			Msg:  "Teams Title is empty",
+			Msg:  "teams: empty title",
 		}
 	}
 	if s.MessageTemplate == "" {
 		return &influxdb.Error{
 			Code: influxdb.EInvalid,
-			Msg:  "Teams MessageTemplate is empty",
+			Msg:  "teams: empty messageTemplate",
 		}
 	}
 	return nil
 }
 
 // Type returns the type of the rule config.
 func (s Teams) Type() string {
-	return "teams"
+	return endpoint.TeamsType
 }
diff --git a/notification/rule/teams_test.go b/notification/rule/teams_test.go
@@ -272,7 +272,7 @@ func TestTeams_Valid(t *testing.T) {
 			},
 			err: &influxdb.Error{
 				Code: influxdb.EInvalid,
-				Msg:  "Teams MessageTemplate is empty",
+				Msg:  "teams: empty messageTemplate",
 			},
 		},
 		{
@@ -297,7 +297,7 @@ func TestTeams_Valid(t *testing.T) {
 			},
 			err: &influxdb.Error{
 				Code: influxdb.EInvalid,
-				Msg:  "Teams Title is empty",
+				Msg:  "teams: empty title",
 			},
 		},
 		{