Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[1.x,2.x] Respect errors in array cursors - TSM cleanup [Port to 1.11] #24824

Closed
davidby-influx opened this issue Mar 25, 2024 · 0 comments · Fixed by #24894
Closed

[1.x,2.x] Respect errors in array cursors - TSM cleanup [Port to 1.11] #24824

davidby-influx opened this issue Mar 25, 2024 · 0 comments · Fixed by #24894
Assignees
@davidby-influx
Labels
1.x area/queries kind/bug team/edge

Comments

@davidby-influx
Copy link
Contributor

Port #24789 to 1.11 branch
@davidby-influx davidby-influx self-assigned this Mar 25, 2024
davidby-influx added a commit that referenced this issue Apr 5, 2024
@davidby-influx
fix: return and respect cursor errors (#24791)
18db4c1 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789
---------
Co-authored-by: Stuart Carnie <[email protected]>

(cherry picked from commit fe6c64b)

closes #24824
@davidby-influx davidby-influx mentioned this issue Apr 5, 2024
Merged
@davidby-influx davidby-influx linked a pull request Apr 5, 2024 that will close this issue
fix: return and respect cursor errors (#24791) #24894
Merged
davidby-influx added a commit that referenced this issue Apr 8, 2024
@davidby-influx
fix: return and respect cursor errors (#24791) (#24894)
727eb09 
ArrayCursors were ignoring errors, which led to panics when nil
cursors were operated on. This fix passes errors back up the stack
and uses them to enforce healthy cursor creation.

Closes #24789

Co-authored-by: Stuart Carnie <[email protected]>

(cherry picked from commit fe6c64b)

closes #24824
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@davidby-influx davidby-influx

Labels
1.x area/queries kind/bug team/edge
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: return and respect cursor errors (#24791) influxdata/influxdb
1 participant
@davidby-influx