chore: upgrade flux to v0.167.0 in 1.10 #23350
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
bnpfeife
commented
May 17, 2022
bnpfeife
commented
- Well-formatted commit messages
- Rebased/mergeable
- Tests pass
bnpfeife
changed the title
serenibyss
previously approved these changes
May 17, 2022
| @@ -46,7 +46,6 @@ func (cmd *Command) Run(args ...string) error { | |||
| return err | |||
| } | |||
|
|
|||
| dataPath := filepath.Join(path, "data") | |||
There was a problem hiding this comment.
Did you mean to include this change (would result in a backport of #23336) in this PR?
There was a problem hiding this comment.
Oh, good catch! I forced pushed a branch without the commit.
* chore: update flux to latest version * fix: backport "convert allocator to interface" * fix: construct `span` during dependency injection
bnpfeife
force-pushed
the
BNP_fix_flux_integration_1.10
branch
from
7e22e15 to
cf2ee38
Compare
serenibyss
approved these changes
May 17, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.