fix tests to cope with future changes to testing.quick.Check - see #5854 #5855
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Submitted a zero-change PR which shows that origin/master tests failed when compiled with go/master but not with go/go1.6. This build should fail. |
jonseymour
changed the title
jonseymour
changed the title
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
from
c0104cb to
8dc4018
Compare
|
Output of build @ 8dc4018: |
|
The issue is that a nil []bool slice when round tripped through encoding and decoding becomes []bool{}. |
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
3 times, most recently
from
e0e8ce4 to
90bfc13
Compare
|
90bfc13 passed with this test run - https://circleci.com/gh/influxdata/influxdb/9927 |
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
from
90bfc13 to
ecf8ad7
Compare
jonseymour
changed the title
|
Thanks to David Cheney and @marcosnils for the analysis that pin-pointed the issue. |
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
from
ecf8ad7 to
babb27e
Compare
|
glad to help!. |
This was referenced Feb 29, 2016
Closed
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
from
babb27e to
dba495a
Compare
|
Rebased onto v0.10.0 because the same commit would be useful if/when there is a 0.10.2 release. |
…ing.quick.Check in go master The current go compiler at the tip of the go master (1d5001af) has a modified implementation of testing.quick.Check that now generates nil slices as test data. (See: https://gophers.slack.com/archives/general/p14567053570110). The existing tests expect round tripping to work in this case but it does not. So, in these cases we change the expectation to reflect actual behaviour. This needs to be checked for reasonableness.
RHS merges cleanly with 0.10.0 Signed-off-by: Jon Seymour <[email protected]>
Signed-off-by: Jon Seymour <[email protected]>
jonseymour
force-pushed
the
jss-5854-go-master-breaks-build
branch
from
dba495a to
a01d020
Compare
jonseymour
changed the title
|
This PR is no longer required to workaround the CI build issues. However, it probably still is required because inevitably influxdb will need to use a later version of go which does include a version of testing.quick.Check which will cause spurious failures of 4 tests. |
|
👍 Thanks @jonseymour |
jwilder
added a commit
that referenced
this pull request
Mar 2, 2016
fix tests to cope with future changes to testing.quick.Check - see #5854
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This test case demonstrates that go master breaks the influxdb build, but go 1.6 doesn't. See #5854