Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove the pidfile after the server has exited #8987

Merged
merged 1 commit into from
Oct 20, 2017
Merged

Remove the pidfile after the server has exited #8987

merged 1 commit into from
Oct 20, 2017

Conversation

jsternberg
Copy link
Contributor

@jsternberg jsternberg commented Oct 19, 2017 •
edited
Loading

Fixes #8983.

  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated

@ghost ghost assigned jsternberg Oct 19, 2017
@ghost ghost added the review label Oct 19, 2017
@jsternberg jsternberg force-pushed the js-8983-remove-pid-file branch from 758be02 to 2005a8c Compare October 19, 2017 21:34
e-dard
e-dard approved these changes Oct 20, 2017
View reviewed changes
Copy link
Contributor

@e-dard e-dard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@jsternberg jsternberg merged commit 8c42345 into master Oct 20, 2017
@jsternberg jsternberg deleted the js-8983-remove-pid-file branch October 20, 2017 14:16
@ghost ghost removed the review label Oct 20, 2017
@thibodux thibodux mentioned this pull request Oct 20, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@e-dard e-dard e-dard approved these changes

Assignees

@jsternberg jsternberg

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jsternberg @e-dard