Fix case-sensitivity of Telegram parse mode values. #1168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rossmcdonald
approved these changes
Feb 3, 2017
|
@nathanielc Is this okay to merge? |
nathanielc
added a commit
that referenced
this pull request
Feb 13, 2017
…ion-markdown-should-be-case-insensitive Fix case-sensitivity of Telegram parse mode values.
Appeltabak
deleted the
1133-telegram-parsemode-option-markdown-should-be-case-insensitive
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the case-sensitivity of Telegram
parseModevalues. This is done by lower-casing those values before validation.I don't know where and how to test this, so I left that out of this PR. Let me know if this is required and how I can add them.
Fixes #1133
Required for all non-trivial PRs