Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update static-discovery config to supply __address__ #1387

Merged
merged 2 commits into from
May 18, 2017

Conversation

goller
Copy link
Contributor

@goller goller commented May 18, 2017

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)

Problem

The static-discovery configuration was difficult to use:
Previously, it had a prometheus assumption of __address__ as a target:

[[static-discovery]]
  enabled = true
  id = "mystatic"
  targets = [{ "__address__" = "localhost:9100"}]
  [static.labels]
    region = "us-east-1"

Solution

The static-discovery configuration section has been simplified to look like this:

[[static-discovery]]
  enabled = true
  id = "mystatic"
  targets = ["localhost:9100"]
  [static.labels]
    region = "us-east-1"

@nathanielc nathanielc merged commit 3b7635b into master May 18, 2017
nathanielc added a commit that referenced this pull request May 18, 2017
Update static-discovery config to supply __address__
@nathanielc nathanielc deleted the go-simplify-static-discovery branch May 18, 2017 19:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants