Change configuration package to influxdata/config #155
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
force-pushed
the
tr-config
branch
2 times, most recently
from
ab82c87 to
8778b7f
Compare
|
@timraymond I am testing locally and this looks good. I will need to wait for InfluxDB core to merge their config first since mine config imports some of their config. |
|
Link to InfluxDB PR influxdata/influxdb#5401 |
We are unifying the way that we handle configuration across the products into the influxdata/config package. This provides the same API as the BurntSushi/toml package used previously, but uses influxdata/toml under the hood (which is a fork of naoina/toml). The underlying toml parser has been changed because Telegraf uses specific features of this parser that cannot be easily replicated with the BurntSushi parser. Furthermore, our fork of naoina/toml provides support for maps and pointers within structs and toml documentation facilities[1]. [1] This is accessible by adding a “doc” struct tag with a comment describing a particular field of a config struct. When marshalling that struct as TOML, the “doc” struct tag will be placed appropriately to document that field in the resultant TOML output.
|
@timraymond As per the issues found with the config package this PR is not viable in the near future. I am going to close the PR. We can open a new one once we have fixed influxdb/config |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We are unifying the way that we handle configuration across the products into
the influxdata/config package. This provides the same API as the
BurntSushi/toml package used previously, but uses influxdata/toml under the
hood (which is a fork of naoina/toml). The underlying toml parser has been
changed because Telegraf uses specific features of this parser that cannot be
easily replicated with the BurntSushi parser. Our fork of naoina/toml provides
support for maps and pointers within structs and toml documentation[1]
facilities, which the original does not, at present time (pull requests have
been submitted with no response with no response from the maintainer).
[1] This is accessible by adding a “doc” struct tag with a comment describing a
particular field of a config struct. When marshalling that struct as TOML, the
“doc” struct tag will be placed appropriately to
document that field in the resultant TOML output.