sysUpTime addition to snmptrap #1581
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nathanielc
suggested changes
Oct 9, 2017
services/snmptrap/service.go
Outdated
| } | ||
| varBinds = append(varBinds, snmpgo.NewVarBind(snmpgo.OidSnmpTrap, oid)) |
There was a problem hiding this comment.
No need to append here, you can simply declare them both in the literal array above.
varBinds := snmpgo.VarBinds{
snmpgo.NewVarBind(snmpgo.OidSnmpTrap, oid),
snmpgo.NewVarBind(snmpgo.OidSysUpTime, snmpgo.NewTimeTicks(1000)),
}
nradonicich
force-pushed
the
sysUpTime_addition
branch
from
68d9e54 to
0c2dd37
Compare
|
I made the requested changes (CircleCI the passed the build) however CircleCI is now failing the build after I rebased/squash (and admittedly force updated to github) while it is completing properly on my localhost with the changes. Is there a way to retry the build in CircleCI? |
nathanielc
approved these changes
Oct 10, 2017
nathanielc
added a commit
that referenced
this pull request
Oct 10, 2017
sysUpTime addition to snmptrap
|
@nradonicich Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updated snmptrap service to fix #1541
Required for all non-trivial PRs