Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow kapacitor.udf.agent to be importable under python 3 #1799

Closed
wants to merge 1 commit into from

Conversation

swails
Copy link

@swails swails commented Feb 9, 2018

Required for all non-trivial PRs
  • Rebased/mergable
  • Tests pass
  • CHANGELOG.md updated
  • Sign CLA (if not already signed)
Required only if applicable

You can erase any checkboxes below this note if they are not applicable to your Pull Request.

@swails
Copy link
Author

swails commented Feb 9, 2018

Following these changes, kapacitor.udf.agent is importable under Python 3.

Does the CircleCI checkmark indicate that "Tests pass"? It wasn't clear to me in the logs of the output if that was true. If not, how do I run the tests?

@nathanielc
Copy link
Contributor

@swails Does this work for you? Others have attempted similar changes but ran into further issues. See #1355 and #1750

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants