Added Talk service for alerting. #194
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -388,6 +390,16 @@ func (s *Server) appendReportingService(c reporting.Config) { | |||
| } | |||
| } | |||
|
|
|||
| func (s *Server) appendTalkService(c talk.Config) { | |||
| if c.Enabled { | |||
| l := s.LogService.NewLogger("[jiaoliao] ", log.LstdFlags) | |||
There was a problem hiding this comment.
Why not [talk] since that is how its referred in the code base?
|
@wutaizeng Overall this looks good, just some minor comments to address. Also if you haven't already be sure to sign the CLA. |
added 2 commits
February 3, 2016 10:02
- Replace [jianliao] with [talk]. - Remove change with Sensu. - Remove level parameter. - Add a blurb on how to create Talk webhook.
nathanielc
pushed a commit
that referenced
this pull request
Feb 5, 2016
Added Talk service for alerting.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Talk is a very popular chat tools in China, our team is using it as a endpoint to accept alerting.