RFC: Feature. Allow for overriding OpsGenieV2's alert recovery action #2301
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zabullet
changed the title
|
Any reason PRs are languishing? |
|
@zabullet sorry it has taken so long, this is next on my list after I finish fixing a panic, and have a little bit of enterprise edition work to do. |
docmerlin
approved these changes
May 20, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows the addition of the .RecoveryAction(...) method to the chain of the opsGenie2 service. Historically the recovery action was either close|notes set in the global config which didn't allow uses cases where specific scripts wanted to deviate from the default behavior.
RFC: I'm not sure I fully grokked the model and pattern for config in kapacitor so would be good to make get some input on this.
TBC: Update documentation
Required for all non-trivial PRs