feat: httpPost url templating #2388
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This closes #2387 |
docmerlin
force-pushed
the
template-url
branch
from
7a87c24 to
65e21ea
Compare
ayang64
approved these changes
Aug 27, 2020
| @@ -85,14 +89,24 @@ func (e *Endpoint) RowTemplate() *template.Template { | |||
| return e.rowTemplate | |||
| } | |||
|
|
|||
| func (e *Endpoint) NewHTTPRequest(body io.Reader) (req *http.Request, err error) { | |||
| func (e *Endpoint) URL() *template.Template { | |||
There was a problem hiding this comment.
just curious: will the address of e.urlTemplate change? is it safe to return its address without locking?
There was a problem hiding this comment.
It should be safe to do this in our case, furthermore, as we are storing a template.Template, so the address won't change relative to the object's address.
This allows for templating urls in post alerts and in httpPost nodes.
docmerlin
force-pushed
the
template-url
branch
from
65e21ea to
3284960
Compare
ayang64
approved these changes
Aug 27, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds templating to the url for httpPost.