fix: Zenoss config handling #2549
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sranka
reviewed
May 12, 2021
alespour
force-pushed
the
fix/zenoss-external-testing-again
branch
from
6d71488 to
bf548ed
Compare
sranka
requested changes
May 14, 2021
sranka
reviewed
May 14, 2021
sranka
approved these changes
May 15, 2021
sranka
requested changes
May 17, 2021
There was a problem hiding this comment.
Can you please also rename json properties in https://github.com/influxdata/kapacitor/blob/master/services/zenoss/service.go#L87-L88 , so that these props are always the same (evclasskey, evclass)
sranka
requested changes
May 17, 2021
There was a problem hiding this comment.
You also might consider changing "TID" to "tid" in
https://github.com/influxdata/kapacitor/blob/master/pipeline/tick/alert.go#L266
so it is consistent with config and other namings of the same property
|
@sranka json props names unified. |
sranka
approved these changes
May 17, 2021
alespour
force-pushed
the
fix/zenoss-external-testing-again
branch
from
def352b to
3e6bbef
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
More fixes to Zenoss:
URLand authentication info (username,password) removed from handler configcollectorproperty is configurable item as it is unlikely to be changed per alertTestOptions())Required for all non-trivial PRs