chore: update go to 1.18 and refactor to take advantage of some of it… #2687
+128
−702
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidby-influx
requested changes
Jun 15, 2022
circularqueue.go
Outdated
| } | ||
| } | ||
|
|
||
| // Enqueue adds an item to the queue. | ||
| func (q *timeMessageCircularQueue) Enqueue(v timeMessage) { | ||
| func Enqueue[T any](q *CircularQueue[T], v T) { |
There was a problem hiding this comment.
Can this be a receiver function, or is there some generics issue with that?
circularqueue.go
Outdated
| q.head = 0 | ||
| q.tail = 0 | ||
| } | ||
| return | ||
| } | ||
|
|
||
| // Peek peeks i ahead of the current head of queue. It should be used in conjunction with .Len() to prevent a panic. | ||
| func (q *timeMessageCircularQueue) Peek(i int) timeMessage { | ||
| if i < 0 || i >= q.l { | ||
| func Peek[x any](q *CircularQueue[x], i int) x { |
There was a problem hiding this comment.
Can this be a receiver function?
services/load/service.go
Outdated
| return errors.New("expected id to be topicID/handlerID") | ||
| topicID, handlerID, found := strings.Cut(id, "/") | ||
| if !found { | ||
| return errors.New("expected id to be topicID/handlerID but it was: \"" + id + "\"") |
There was a problem hiding this comment.
Perhaps use fmt.Errorf here.
davidby-influx
approved these changes
Jun 16, 2022
| @@ -603,7 +603,7 @@ func (s *Service) removeHandlers() error { | |||
| for _, id := range diff(s.handlers, loadedHandlers) { | |||
| topicID, handlerID, found := strings.Cut(id, "/") | |||
| if !found { | |||
| return errors.New("expected id to be topicID/handlerID but it was: \"" + id + "\"") | |||
| return fmt.Errorf("expected id to be topicID/handlerID but it was: \"%s\"", id) | |||
There was a problem hiding this comment.
non-blocking - I like %q over \"%s\" because it escapes bad characters and looks cleaner in the formatting string.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.