[WIP] Allow for UDF communication over a Unix Socket #442
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
nathanielc
force-pushed
the
nc-issue#417
branch
3 times, most recently
from
7319bf3 to
d1187ab
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #417
Now you can configure a UDF as a Unix Socket instead of having Kapacitor spawn a subprocess.
This enables the use of UDFs from within Docker. Start Kapacitor in its own container and mount socket files from other containers which are the UDF processes.
The original mechanism to spawn a subprocess still works and is unchanged.
TODO:
Note since the UDF code we significantly restructured in this PR it fixes #441.