Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix issue with nested binary operators counting as constant typed #567

Merged
merged 3 commits into from
May 20, 2016
+417 −357
Merged

Fix issue with nested binary operators counting as constant typed #567

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3d2d173
fix issue with nested binary operators counting as constant typed
nathanielc May 19, 2016
b18b911
update for IsLogical
nathanielc May 19, 2016
5b32eb3
refactor names to be consitent
nathanielc May 19, 2016
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
update for IsLogical
@nathanielc
nathanielc committed May 19, 2016
commit b18b911162587dc78c060940a8a11b8c3078dbb3
2 changes: 1 addition & 1 deletion tick/stateful/types.go
View file
Original file line number Diff line number Diff line change
@@ -109,7 +109,7 @@ func getConstantNodeType(n tick.Node) ValueType {
return TString
}
}
if tick.IsCompOperator(node.Operator) {
if tick.IsCompOperator(node.Operator) || tick.IsLogicalOperator(node.Operator) {
return TBool
}