Initial auth plumbing #702
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| default: | ||
| return AllPrivileges, fmt.Errorf("unknown method %q", m) | ||
| } | ||
| } |
There was a problem hiding this comment.
Wondering if authorizing the HTTP request is the right way to go or if it should be somewhere below the transport layer. Thoughts?
….git vendor/github.com/dgrijalva/jwt-go subrepo: subdir: "vendor/github.com/dgrijalva/jwt-go" merged: "d2709f9" upstream: origin: "https://github.com/dgrijalva/jwt-go.git" branch: "v3.0.0" commit: "d2709f9" git-subrepo: version: "0.3.0" origin: "???" commit: "???"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds basic plumbing for authenticating and authorizing requests.
The basic design has two kinds of user actions that can be controlled.