fix(inputs.upsd): Ensure firmware is always a string (#12486)

influxdata · Jan 12, 2023 · b6b0b80 · b6b0b80
1 parent 6f323ee
commit b6b0b80
Showing 1 changed file with 7 additions and 1 deletion.
diff --git a/plugins/inputs/upsd/upsd.go b/plugins/inputs/upsd/upsd.go
@@ -7,6 +7,7 @@ import (
 	"strings"
 
 	"github.com/influxdata/telegraf"
+	"github.com/influxdata/telegraf/internal"
 	"github.com/influxdata/telegraf/internal/choice"
 	"github.com/influxdata/telegraf/plugins/inputs"
 	nut "github.com/robbiet480/go.nut"
@@ -83,10 +84,15 @@ func (u *Upsd) gatherUps(acc telegraf.Accumulator, name string, variables []nut.
 		"nominal_input_voltage":   metrics["input.voltage.nominal"],
 		"nominal_battery_voltage": metrics["battery.voltage.nominal"],
 		"nominal_power":           metrics["ups.realpower.nominal"],
-		"firmware":                metrics["ups.firmware"],
 		"battery_date":            metrics["battery.mfr.date"],
 	}
 
+	val, err := internal.ToString(metrics["ups.firmware"])
+	if err != nil {
+		acc.AddError(fmt.Errorf("converting ups.firmware=%v failed: %v", metrics["ups.firmware"], err))
+	}
+	fields["firmware"] = val
+
 	acc.AddFields("upsd", fields, tags)
 }