-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test: add test for mysql gatherGlobalVariables using sql-mock #10036
Conversation
😄 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here! 🐯Artifact URLs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding more tests!
Hi, Would love to take more tests, however, it looks like the PR tests and lint are failing. Can you take a look at the failures? Thanks! |
👍 This pull request doesn't change the Telegraf binary size 📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
@fxedel would you be willing to rebase this PR so we can get this landed? Thanks! |
Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you! |
Required for all PRs:
Updated associated README.md.See #8561
Add a test that doesn't need a real database connection (by using sql-mock) and asserts proper parsing of the SQL query result.
I already found some issues with the version tag by adding this test, but I'd recommend adding the tests first and fixing the issues afterwards.