Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: input plugin statsd bug #10116

Merged
merged 4 commits into from
Nov 23, 2021

Conversation

rentiansheng
Copy link
Contributor

@rentiansheng rentiansheng commented Nov 17, 2021

Required for all PRs:

resolves #

fix bug:

      line ="uri=/service/endpoint?sampleParam={paramValue}"
      parse result  key="uri", val="/service/endpoint?sampleParam\={paramValue}"

format

file: config/config.go adjust the deprecated position, some IDE can disply strikethrough, eg: goland

@telegraf-tiger
Copy link
Contributor

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Nov 17, 2021
@rentiansheng
Copy link
Contributor Author

!signed-cla

Copy link
Contributor

@sspaink sspaink left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for looking into fixing this problem, I've added two comments for you to look at.

@sspaink sspaink changed the title Fix input plugin statsd bug fix: input plugin statsd bug Nov 18, 2021
@rentiansheng rentiansheng force-pushed the fix_input_plugin_statsd_bug branch from 73f0f98 to 52cbf17 Compare November 19, 2021 05:32
@rentiansheng rentiansheng reopened this Nov 19, 2021
@rentiansheng rentiansheng force-pushed the fix_input_plugin_statsd_bug branch from 52cbf17 to fb5aba8 Compare November 19, 2021 06:17
@rentiansheng rentiansheng requested a review from sspaink November 22, 2021 03:59
@telegraf-tiger
Copy link
Contributor

@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Nov 23, 2021
@powersj powersj merged commit cd0a7cd into influxdata:master Nov 23, 2021
reimda pushed a commit that referenced this pull request Dec 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

statsd plugin sanitizes '?'
3 participants