feat: add support for OpenSearch to existing ElasticSearch output plugin #10390
Conversation
|
Thanks so much for the pull request! |
telegraf-tiger
bot
added
the
feat
|
!signed-cla |
|
@pteich Peter, |
|
@StefanSa I'll have a look and also resolve the conflicts. |
|
@pteich Peter, Grüße nach Leipzig |
* master: (117 commits) fix: bump github.com/nats-io/nats-server/v2 from 2.6.5 to 2.7.2 (influxdata#10638) chore: add -race flag to go tests (influxdata#10629) feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10631) fix: license doc outdated causing CI failure (influxdata#10630) fix: bump k8s.io/client-go from 0.22.2 to 0.23.3 (influxdata#10589) feat: Implemented support for reading raw values, added tests and doc (influxdata#6501) fix: Improve parser tests by using go-cmp/cmp (influxdata#10497) feat(mongodb): add FsTotalSize and FsUsedSize informations (influxdata#10625) docs: update quay docs for auth (influxdata#10612) chore: allow downgrade of go version in windows script (influxdata#10614) chore: update CI go to 1.17.6 (influxdata#10611) feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10600) fix(inputs.opcua): add more data to error log (influxdata#10465) fix: bump github.com/aws/aws-sdk-go-v2/service/kinesis from 1.6.0 to 1.13.0 (influxdata#10601) refactor: use early return pattern (influxdata#10591) fix: bump github.com/benbjohnson/clock from 1.1.0 to 1.3.0 (influxdata#10588) feat: add dynamic tagging to gnmi plugin (influxdata#7484) fix: bump github.com/Azure/azure-kusto-go from 0.5.0 to 0.5.2 (influxdata#10598) feat: update etc/telegraf.conf and etc/telegraf_windows.conf (influxdata#10584) fix(parsers.json_v2): allow optional paths and handle wrong paths correctly (influxdata#10468) ... # Conflicts: # plugins/outputs/elasticsearch/elasticsearch.go # plugins/outputs/elasticsearch/elasticsearch_test.go
|
The team chatted about the way we wanted to fix this and instead put up #10586. The PR documents the method that Amazon has given to enable compatibility with Elasticsearch clients. It is best if users use this method rather than trying to set options in Telegraf itself. One of the reasons is we do not like to add boolean values due to potential conflicts in the future. For example, right now this PR would set the major version to 7. However, it is entirely possible that Amazon moves to Elasticsearch 8 or 9 in the future. If there are additional major version checks added in the future the boolean would have to know more about which version to use. I appreciate that you took the time to put this up, but I am going to close it as we have landed the other PR. Thanks |
Required for all PRs:
resolves #9414
This PR adds support for OpenSearch to the existing ElasticSearch output plugin. OpenSearch is based on ElasticSearch 7.x but it introduces its own versioning. Because of this the current version reports 1.2.3 and this breaks the version check implementation.
To make it work with OpenSearch servers this PR introduces a new config setting
opensearch = truethat circumvents the version check and internal treats the server as a major version 7 ElasticSearch (because this is needed for other internal checks).The new config setting also enables to react to other potentially OpenSearch additions in the future.