Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: correctly set ASCII trailer for syslog output #10393

Merged
merged 1 commit into from
Jan 11, 2022
Merged

fix: correctly set ASCII trailer for syslog output #10393

merged 1 commit into from
Jan 11, 2022

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 6, 2022

Fixes: #10392

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 6, 2022
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Jan 6, 2022

👍 This pull request doesn't change the Telegraf binary size

📦 Looks like new artifacts were built from this PR.

Expand this list to get them here ! 🐯

Artifact URLs

DEB RPM TAR GZ ZIP
amd64.deb aarch64.rpm darwin_amd64.tar.gz windows_amd64.zip
arm64.deb armel.rpm darwin_arm64.tar.gz windows_i386.zip
armel.deb armv6hl.rpm freebsd_amd64.tar.gz
armhf.deb i386.rpm freebsd_armv7.tar.gz
i386.deb ppc64le.rpm freebsd_i386.tar.gz
mips.deb riscv64.rpm linux_amd64.tar.gz
mipsel.deb s390x.rpm linux_arm64.tar.gz
ppc64el.deb x86_64.rpm linux_armel.tar.gz
riscv64.deb linux_armhf.tar.gz
s390x.deb linux_i386.tar.gz
linux_mips.tar.gz
linux_mipsel.tar.gz
linux_ppc64le.tar.gz
linux_riscv64.tar.gz
linux_s390x.tar.gz
static_linux_amd64.tar.gz

srebhan
srebhan approved these changes Jan 11, 2022
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan self-assigned this Jan 11, 2022
@srebhan srebhan added area/syslog ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. labels Jan 11, 2022
@MyaLongmire MyaLongmire merged commit bccecef into influxdata:master Jan 11, 2022
@powersj powersj deleted the fix/syslog-trailer branch January 11, 2022 22:15
powersj added a commit to powersj/telegraf that referenced this pull request Jan 21, 2022
@powersj
fix: correctly set ASCII trailer for syslog output (influxdata#10393)
b847909
reimda pushed a commit that referenced this pull request Jan 27, 2022
@powersj @reimda
fix: correctly set ASCII trailer for syslog output (#10393)
8f6f081 
(cherry picked from commit bccecef)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MyaLongmire MyaLongmire MyaLongmire approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
area/syslog fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

syslog output: not using correct ASCII trailers per RFC 6587
3 participants
@powersj @MyaLongmire @srebhan