Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: sanitize stasd names #10466

Merged
merged 3 commits into from
Mar 1, 2022
Merged

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Jan 19, 2022

Per upstream, statsd does sanitization of names. This takes this same
set of rules and applies it when statsd is parsing out names.

Without these, the names were getting garbled or partially dropped.

Fixes: #10372
Fixes: #5662

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Jan 19, 2022
@powersj powersj marked this pull request as ready for review February 22, 2022 21:42
@powersj powersj force-pushed the fix/statsd-sanitize branch from 128a1ff to e00e9bd Compare February 23, 2022 17:43
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Feb 23, 2022
Per upstream, statsd does sanitization of names. This takes this same
set of rules and applies it when statsd is parsing out names when the
sanitize option is set to upstream.

Fixes: influxdata#10372
@powersj powersj force-pushed the fix/statsd-sanitize branch from e00e9bd to bcede7d Compare February 25, 2022 19:56
@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 1, 2022

@powersj powersj merged commit 39e065f into influxdata:master Mar 1, 2022
@powersj powersj deleted the fix/statsd-sanitize branch March 1, 2022 22:01
MyaLongmire pushed a commit that referenced this pull request Jul 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
3 participants