-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: sanitize stasd names #10466
Merged
Merged
fix: sanitize stasd names #10466
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Looks like new artifacts were built from this PR. Expand this list to get them here ! 🐯Artifact URLs |
reimda
reviewed
Feb 22, 2022
powersj
force-pushed
the
fix/statsd-sanitize
branch
from
February 23, 2022 17:43
128a1ff
to
e00e9bd
Compare
powersj
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Feb 23, 2022
powersj
commented
Feb 24, 2022
Per upstream, statsd does sanitization of names. This takes this same set of rules and applies it when statsd is parsing out names when the sanitize option is set to upstream. Fixes: influxdata#10372
powersj
force-pushed
the
fix/statsd-sanitize
branch
from
February 25, 2022 19:56
e00e9bd
to
bcede7d
Compare
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 📦 Click here to get additional PR build artifactsArtifact URLs |
sspaink
approved these changes
Mar 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per upstream, statsd does sanitization of names. This takes this same
set of rules and applies it when statsd is parsing out names.
Without these, the names were getting garbled or partially dropped.
Fixes: #10372
Fixes: #5662