Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

style: Add deprecated warning and version to win_perf_counters option #10579

Merged
merged 1 commit into from
Feb 3, 2022
Merged

style: Add deprecated warning and version to win_perf_counters option #10579

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion plugins/inputs/win_perf_counters/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -87,7 +87,7 @@ Example:

#### PreVistaSupport

(Deprecated. Necessary features on Windows Vista and newer are checked dynamically)
(Deprecated in 1.7; Necessary features on Windows Vista and newer are checked dynamically)

Bool, if set to `true`, the plugin will use the localized PerfCounter interface that has been present since before Vista for backwards compatibility.

Expand Down
5 changes: 2 additions & 3 deletions plugins/inputs/win_perf_counters/win_perf_counters.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -150,9 +150,8 @@ var sampleConfig = `
`

type Win_PerfCounters struct {
PrintValid bool
//deprecated: determined dynamically
PreVistaSupport bool
PrintValid bool `toml:"PrintValid"`
PreVistaSupport bool `toml:"PreVistaSupport" deprecated:"1.7.0;determined dynamically"`
UsePerfCounterTime bool
Object []perfobject
CountersRefreshInterval config.Duration
Expand Down