-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(parsers.json_v2): Check if gpath exists and support optional in fields/tags #10799
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Mar 9, 2022
sspaink
added
the
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
label
Mar 9, 2022
kitlaan
reviewed
Mar 9, 2022
kitlaan
approved these changes
Mar 9, 2022
reimda
reviewed
Mar 10, 2022
update docs to remove PR reference
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
reimda
approved these changes
Mar 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
fix
pr to fix corresponding bug
ready for final review
This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolve: #10670
resolve: #10776
#10468 introduced a bug by checking if a gpath exists by comparing the return type to
null
, which preventednull
being allowed in a JSON file. Instead it should have used the providedExists()
method as suggested in #10670 by @kitlaan and @kgrimsby thanks! 🎉. This PR updates the parser to useExists()
when appropriate. It was also suggested to error only after all the paths have been checked which seems like a good idea, but I am hesitant introducing that into this fix because it does change behavior and maybe keeping this PR just to fix the bug?#10468 introduced the configuration option
optional
so that the json_v2 parser can work better with the mqtt_consumer plugin when the paths aren't guaranteed in the JSON. This PR overlooked the global field and tag to include the configuration as well, this was pointed out in #10776. This PR allows settingoptional
to field and tag as well.