Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(parsers.json_v2): Check if gpath exists and support optional in fields/tags #10799

Merged
merged 6 commits into from
Mar 11, 2022

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Mar 9, 2022

resolve: #10670
resolve: #10776

#10468 introduced a bug by checking if a gpath exists by comparing the return type to null, which prevented null being allowed in a JSON file. Instead it should have used the provided Exists() method as suggested in #10670 by @kitlaan and @kgrimsby thanks! 🎉. This PR updates the parser to use Exists() when appropriate. It was also suggested to error only after all the paths have been checked which seems like a good idea, but I am hesitant introducing that into this fix because it does change behavior and maybe keeping this PR just to fix the bug?

#10468 introduced the configuration option optional so that the json_v2 parser can work better with the mqtt_consumer plugin when the paths aren't guaranteed in the JSON. This PR overlooked the global field and tag to include the configuration as well, this was pointed out in #10776. This PR allows setting optional to field and tag as well.

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 9, 2022
@sspaink sspaink marked this pull request as ready for review March 9, 2022 19:52
@sspaink sspaink added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 9, 2022
@reimda reimda merged commit b526945 into master Mar 11, 2022
@reimda reimda deleted the fixjsonv2pathexists branch March 11, 2022 19:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Json_v2 optional only works on objects not on root json_v2 parser and NULL values
3 participants