fix(config): return error on order set as string #12880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Order should be a number, not a string, so instead of silently failing we should call the user to action. fixes: influxdata#12879
powersj
added
the
ready for final review
|
Would you prefer this attempt to parse a string to an int first? Or tell and expect the user to use an int? Currently we are silently ignoring the value, and so a user using processors with a string order is not getting the order they want. |
|
Download PR build artifacts for linux_amd64.tar.gz, darwin_amd64.tar.gz, and windows_amd64.zip. 👍 This pull request doesn't change the Telegraf binary size 📦 Click here to get additional PR build artifactsArtifact URLs |
Hipska
reviewed
Mar 21, 2023
srebhan
pushed a commit
that referenced
this pull request
Apr 3, 2023
(cherry picked from commit f1da63d)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Order should be a number, not a string, so instead of silently failing we should call the user to action.
fixes: #12879