Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.timestream): Clip uint64 values #14213

Merged
merged 2 commits into from
Oct 31, 2023

Conversation

powersj
Copy link
Contributor

@powersj powersj commented Oct 30, 2023

Timestream does not support uint64 values. Instead of returning an error, this will return values less than the max uint64 and cap values larger.

fixes: #14212

@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Oct 30, 2023
@powersj powersj marked this pull request as ready for review October 31, 2023 12:56
@powersj powersj added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Oct 31, 2023
@telegraf-tiger
Copy link
Contributor

@srebhan srebhan changed the title fix(outputs.timestream): Cap uint64 values fix(outputs.timestream): Clip uint64 values Oct 31, 2023
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix @powersj!

@srebhan srebhan merged commit 7b7c7b6 into influxdata:master Oct 31, 2023
@github-actions github-actions bot added this to the v1.28.4 milestone Oct 31, 2023
Hipska added a commit to Super-Visions/telegraf that referenced this pull request Nov 2, 2023
…nmp_lookup

* upstream/master:
  chore(linters): Fix findings found by testifylint: expected-actual (influxdata#14229)
  chore(deps): Bump github.com/nats-io/nkeys from 0.4.5 to 0.4.6 (influxdata#14225)
  feat(inputs.procstat)!: Remove useless zero cpu_times (influxdata#14224)
  feat(inputs.gnmi): Rework plugin (influxdata#14091)
  fix(outputs.timestream): Clip uint64 values (influxdata#14213)
  fix(inputs.cgroup): Escape backslashes (influxdata#14187)
  test(outputs.kafka): Use private network for testing (influxdata#14220)
  test(inputs.vault): Fix integration test by only testing for subset (influxdata#14222)
  fix(outputs.elasticsearch): Print error status value (influxdata#14115)
powersj added a commit that referenced this pull request Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Timestream Output Plugin Unconditionally Classifies uint64 to bigint (signed)
2 participants