Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(outputs.bigquery): Add scope to bigquery and remove timeout context #14958

Merged
merged 2 commits into from
Mar 12, 2024
Merged

fix(outputs.bigquery): Add scope to bigquery and remove timeout context #14958

merged 2 commits into from
Mar 12, 2024

Conversation

tgupta3
Copy link
Contributor

@tgupta3 tgupta3 commented Mar 8, 2024

Summary

Checklist

  • No AI generated code was used in this PR

Related issues

resolves #14957

@telegraf-tiger
Copy link
Contributor

telegraf-tiger bot commented Mar 8, 2024

Thanks so much for the pull request!
🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

@tgupta3
Copy link
Contributor Author

tgupta3 commented Mar 8, 2024

Thanks so much for the pull request! 🤝 ✒️ Just a reminder that the CLA has not yet been signed, and we'll need it before merging. Please sign the CLA when you get a chance, then post a comment here saying !signed-cla

!signed-cla

@tgupta3 tgupta3 changed the title Add scope to bigquery and remove timeout context fix(outputs.bigquery): Add scope to bigquery and remove timeout context Mar 8, 2024
@telegraf-tiger telegraf-tiger bot added fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins labels Mar 8, 2024
@tgupta3 tgupta3 marked this pull request as draft March 9, 2024 00:13
@tgupta3 tgupta3 marked this pull request as ready for review March 9, 2024 00:13
@tgupta3 tgupta3 closed this Mar 9, 2024
@tgupta3 tgupta3 reopened this Mar 9, 2024
- Scope was missing for bigquery Client causing ADC to fail.
- Timeout context needs to be removed from connection init, since the dialing happens asynchronously.
https://cloud.google.com/go/docs/reference/cloud.google.com/go/0.94.1#hdr-Timeouts_and_Cancellation
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tgupta3 thanks for your contribution! I do have one question in the code...

@srebhan srebhan self-assigned this Mar 11, 2024
@srebhan srebhan added the area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver label Mar 11, 2024
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the fix @tgupta3!

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Mar 12, 2024
@srebhan srebhan assigned powersj and DStrand1 and unassigned srebhan Mar 12, 2024
@powersj powersj merged commit f723717 into influxdata:master Mar 12, 2024
26 checks passed
@github-actions github-actions bot added this to the v1.30.1 milestone Mar 12, 2024
@tgupta3 tgupta3 deleted the tgupta3-bigquery branch March 12, 2024 15:12
powersj pushed a commit that referenced this pull request Apr 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/gcp Google Cloud plugins including cloud_pubsub, cloud_pubsub_push, stackdriver fix pr to fix corresponding bug plugin/output 1. Request for new output plugins 2. Issues/PRs that are related to out plugins ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Bigquery ADC has missing scope and incorrect context
4 participants