chore(deps): Bump golangci-lint from v1.62.0 to v1.62.2

[zak-pawel]

Summary

• golangci-lint bumped to v1.62.2

• revive:max-public-structs reenabled (following issue has been fixed and released in revive and golangci-lint: The max-public-structs rule starts finding many false positives in version 1.5.0 mgechev/revive#1103

• New findings addressed:

internal/content_coding.go:1:1                  revive  max-public-structs: you have exceeded the maximum number (5) of public struct declarations
metric.go:1:1                                   revive  max-public-structs: you have exceeded the maximum number (5) of public struct declarations
plugins/common/jolokia2/client.go:1:1           revive  max-public-structs: you have exceeded the maximum number (5) of public struct declarations
plugins/common/opcua/input/input_client.go:1:1  revive  max-public-structs: you have exceeded the maximum number (5) of public struct declarations

Checklist

• No AI generated code was used in this PR

[srebhan]

I don't think we should unexport the concrete encoders/decoders! They are helpful if you know the encoding!

[zak-pawel]

I don't think we should unexport the concrete encoders/decoders! They are helpful if you know the encoding!

@srebhan
All these encoders/decoders are available by using NewStreamContentDecoder, NewContentEncoder, NewContentDecoder.

[srebhan]

Yes but if I know I want the gzip decoder, why should I need to do the indirection? I don't see any value in this! Furthermore, the PR is about bumping the linter and you are changing code which is not related to the bump. So please leave the encoding as is.

I see value in limiting the exported stuff for the plugins but not for the rest of the code-base...

[zak-pawel]

So please leave the encoding as is.

@srebhan Changed.

[srebhan]

Can we please move the change of the encoding/decoding things to a separate PR!? The title does not suggest those changes...

[zak-pawel]

The title does not suggest those changes...

@srebhan
But the PR description definitely suggests it 😎 Just in case, it's about addressing new findings for

internal/content_coding.go:1:1                  revive  max-public-structs: you have exceeded the maximum number (5) of public struct declarations

Usually, what we did was that if the bumped golangci-lint started detecting new findings, we fixed them in the same PR. Clean and tidy.

Here are excellent examples:

• chore(tools): Bump golangci-lint from v1.53.2 to v1.54.2 #13838
• chore: Update golangci-lint from v1.58.0 to v1.59.0 #15473

[srebhan]

@zak-pawel I'm a bit puzzled. We agreed on limiting the export stuff to the plugin directories only. So why does it warn for something in internal now? And why didn't it previously?

[zak-pawel]

@zak-pawel I'm a bit puzzled. We agreed on limiting the export stuff to the plugin directories only.

@srebhan Yes! You're right, I totally forgot about that.

So why does it warn for something in internal now? And why didn't it previously?

Because the message format that we have excluded so far has been changed from you have exceeded the maximum number of public struct declarations to you have exceeded the maximum number (5) of public struct declarations. I corrected our filter.

[telegraf-tiger]

Download PR build artifacts for linux_amd64.tar.gz, darwin_arm64.tar.gz, and windows_amd64.zip.
Downloads for additional architectures and packages are available below.

☺️ This pull request doesn't significantly change the Telegraf binary size (less than 1%)

📦 Click here to get additional PR build artifacts

Artifact URLs

DEB	RPM	TAR GZ	ZIP
amd64.deb	aarch64.rpm	darwin_amd64.tar.gz	windows_amd64.zip
arm64.deb	armel.rpm	darwin_arm64.tar.gz	windows_arm64.zip
armel.deb	armv6hl.rpm	freebsd_amd64.tar.gz	windows_i386.zip
armhf.deb	i386.rpm	freebsd_armv7.tar.gz
i386.deb	ppc64le.rpm	freebsd_i386.tar.gz
mips.deb	riscv64.rpm	linux_amd64.tar.gz
mipsel.deb	s390x.rpm	linux_arm64.tar.gz
ppc64el.deb	x86_64.rpm	linux_armel.tar.gz
riscv64.deb		linux_armhf.tar.gz
s390x.deb		linux_i386.tar.gz
		linux_mips.tar.gz
		linux_mipsel.tar.gz
		linux_ppc64le.tar.gz
		linux_riscv64.tar.gz
		linux_s390x.tar.gz

[srebhan]

Thanks @zak-pawel!