Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix single quote parsing of TOML durations #2024

Merged
merged 1 commit into from
Nov 11, 2016
Merged

Fix single quote parsing of TOML durations #2024

merged 1 commit into from
Nov 11, 2016

Conversation

sparrc
Copy link
Contributor

@sparrc sparrc commented Nov 10, 2016 •
edited
Loading

Required for all PRs:

  • CHANGELOG.md updated (we recommend not updating this until the PR has been approved by a maintainer)
  • Sign CLA (if not already signed)
  • README.md updated (if adding a new plugin)

closes #2023

@sparrc sparrc force-pushed the cs2023-single-quote-duration branch from 299fc90 to ddc3688 Compare November 10, 2016 09:43
@sparrc sparrc force-pushed the cs2023-single-quote-duration branch from ddc3688 to 0ecbf9e Compare November 10, 2016 09:47
jwilder
jwilder approved these changes Nov 10, 2016
View reviewed changes
Copy link

@jwilder jwilder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@toddboom
Copy link
Contributor

👍

@toddboom toddboom merged commit b905bc1 into master Nov 11, 2016
@toddboom toddboom deleted the cs2023-single-quote-duration branch November 11, 2016 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jwilder jwilder jwilder approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Single-quotted durations are not being parsed properly
3 participants
@sparrc @toddboom @jwilder