Jolokia configurable HTTP timeouts #2097 #2098
Conversation
There was a problem hiding this comment.
Please decrease the verbosity and use internal.Duration data types, so that these can be written as string durations ("3s")
see latest version of the rabbitmq plugin that I assume this was pulled from: https://github.com/influxdata/telegraf/blob/master/plugins/inputs/rabbitmq/rabbitmq.go#L156-L164
| "github.com/influxdata/telegraf/plugins/inputs" | ||
| ) | ||
|
|
||
| // Default http timeouts | ||
| const DefaultResponseHeaderTimeout = 3 |
There was a problem hiding this comment.
just make these time.Duration objects directly, rather than converting to seconds below
| ## writing the request (including its body, if any). This | ||
| ## time does not include the time to read the response body. | ||
| ## See http.Transport.ResponseHeaderTimeout | ||
| # responseHeaderTimeout = 3 |
There was a problem hiding this comment.
these should match the time format ("3s" and "4s"), and they should be response_header_timeout and client_timeout.
| ## writing the request (including its body, if any). This | ||
| ## time does not include the time to read the response body. | ||
| ## See http.Transport.ResponseHeaderTimeout | ||
| # responseHeaderTimeout = "3s" |
There was a problem hiding this comment.
should be response_header_timeout
| ## Client. The timeout includes connection time, any | ||
| ## redirects, and reading the response body. | ||
| ## See http.Client.Timeout | ||
| # clientTimeout = "4s" |
| ## Optional http timeouts | ||
| ## | ||
| ## ResponseHeaderTimeout, if non-zero, specifies the amount of | ||
| ## time to wait for a server's response headers after fully |
There was a problem hiding this comment.
this is too much writing, decrease the verbosity of this to match the rabbitmq plugin (you'll need to update master to see it)
Required for all PRs: