Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sanitise extra chars in metric and tag names and lowercase outputs #3118

Closed
wants to merge 1 commit into from
Closed

Sanitise extra chars in metric and tag names and lowercase outputs #3118

wants to merge 1 commit into from

Conversation

GROpenSourceDev
Copy link
Contributor

Required for all PRs:

  • [x ] Signed CLA.
  • [na ] Associated README.md updated.
  • [ x] Has appropriate unit tests.

@danielnelson
Copy link
Contributor

I think we need to have a whitelist of characters, according to these docs only these characters are allowed: a to z, A to Z, 0 to 9, -, _, ., / or Unicode letters.

I also don't think we should lower case, since either case is valid.

@danielnelson
Copy link
Contributor

I'm closing in favor of #3227

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/opentsdb
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@GROpenSourceDev @danielnelson