Fix InfluxDB UDP line splitting (#5438) #5439
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| scanner.Split(scanLines) | ||
| for scanner.Scan() { | ||
| _, err = c.conn.Write(scanner.Bytes()) | ||
| } |
There was a problem hiding this comment.
For 1.10, I think I will experiment with doing a metric splitter before the Serialize step, so we don't need to parse the serialized data. There might be some duplication of the serialize code but I think it will be worth it, and also string fields can contain unescaped newlines in line protocol so there is a potential flaw with this (#4942).
I think we are going to do a 1.9.5, and this will be a more appropriate change for it.
There was a problem hiding this comment.
I completely agree doing the change you proposed is a sensible approach. This was just a stopgap to get things working with minimal modifications to the existing code.
danielnelson
pushed a commit
that referenced
this pull request
Feb 19, 2019
(cherry picked from commit 5dfa3fa)
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
otherpirate
pushed a commit
to otherpirate/telegraf
that referenced
this pull request
Mar 15, 2019
dupondje
pushed a commit
to dupondje/telegraf
that referenced
this pull request
Apr 22, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Fixes #5438