New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Input Plugin: GitHub #5587

Merged

danielnelson merged 29 commits into influxdata:master from rawkode:feature/github-input

Apr 2, 2019

Contributor

rawkode commented Mar 15, 2019 •

edited

Loading

Required for all PRs:

Signed CLA.
Associated README.md updated.
Has appropriate unit tests.

rawkode marked this pull request as ready for review

March 15, 2019 17:17

danielnelson suggested changes

View reviewed changes

Contributor

danielnelson left a comment

Looks good, I added more comments than usual about things with things I recommend but aren't required, particularly in the tests.

@goller You should take a look, this might work better for monitoring the repo than the webhook plugin and would be easier to deploy.

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github_test.go Show resolved Hide resolved

plugins/inputs/github/github_test.go Outdated Show resolved Hide resolved

plugins/inputs/github/README.md Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

Gopkg.lock Show resolved Hide resolved

goller reviewed

View reviewed changes

plugins/inputs/github/github.go Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

rawkode added 22 commits

March 28, 2019 15:47


          Initial Commit

f32cc74


          Add github_repository and github_rate_limit measurements


          Add License to Tag List in README

a2f65ed


          Fix Variable Naming and Connect TOML Config

2c379e8


          GitHub Uses the Vocabulary 'Access Token'; Adopting Over APIKey

b6fa54d


          Refactored Code to Smaller Testable Functions


          Removed HAProxy Copy Pasta from README

efd6b3e


          Add Tests for splitRepositoryName

a00aca8


          Add tests for GetLicense

b916a7b


          Add Tests for GetTags and GetFields

383d180


          Update Example Config to Match Style Guide

ab124eb


          Alternating List Starting Char

7723bfe


          Use SelfStat for Rate Limits

aa56ed3


          Remove Redundant NewGitHub Func

d276d47


          Use Single Letter Receiver

51f5584


          Using Provided Error Functions

3058cac


          Use SplitsN

c518d98


          Use SelfStat to Record Blocks by RateLimits

d785526


          Use Testify for Assertions

9ac2c56


          Make Sample Output Match Description

145adcf


          Use TableTests for Split String Function

1d7299f


          Create Our Own HttpClient

4cb4fb6

Contributor Author

rawkode commented Mar 28, 2019

@danielnelson @goller Hopefully I've addressed all the issues 👍

Contributor Author

rawkode commented Mar 28, 2019

I had hoped that by resolving the issues I could re-request a review, but the button still isn't showing 🤷‍♂️

rawkode added 2 commits

March 28, 2019 15:51


          Pass Context to Client Creation

f4ec36c


          Show Access Token as Tag

2032b41

danielnelson suggested changes

View reviewed changes

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/README.md Outdated Show resolved Hide resolved

plugins/inputs/github/README.md Outdated Show resolved Hide resolved

plugins/inputs/github/github.go Outdated Show resolved Hide resolved

plugins/inputs/github/github_test.go Outdated Show resolved Hide resolved

plugins/inputs/github/github_test.go Outdated Show resolved Hide resolved

rawkode added 5 commits

March 29, 2019 12:20


          Update Sample Config to Match README

5b4a443


          Document Internal Metrics

b89f3ae


          Remove Full Name

fba1b3d


          Only Register SelfStats Once


          Clean Up Tests

58a8d22

danielnelson approved these changes

View reviewed changes

danielnelson added the new plugin label

danielnelson added this to the 1.11.0 milestone

danielnelson merged commit 0a68c84 into influxdata:master

rawkode deleted the feature/github-input branch

April 3, 2019 09:11

glinton mentioned this pull request

input.github: undefined but requested #5694

Closed

dupondje pushed a commit to dupondje/telegraf that referenced this pull request


          Add github input plugin (influxdata#5587)

fec4355

hwaastad pushed a commit to hwaastad/telegraf that referenced this pull request


          Add github input plugin (influxdata#5587)

127f236

bitcharmer pushed a commit to bitcharmer/telegraf that referenced this pull request


          Add github input plugin (influxdata#5587)

7ecc7f1

athoune pushed a commit to bearstech/telegraf that referenced this pull request


          Add github input plugin (influxdata#5587)

525ebfe

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels