Ignore errors serializing metrics #5943
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hwaastad
pushed a commit
to hwaastad/telegraf
that referenced
this pull request
Jun 13, 2019
bitcharmer
pushed a commit
to bitcharmer/telegraf
that referenced
this pull request
Oct 18, 2019
athoune
pushed a commit
to bearstech/telegraf
that referenced
this pull request
Apr 17, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using the
Serialize()function to serialize metrics one at a time, sometimes a single metric cannot be serialized. This if often because the particular Serializer does not support a feature of telegraf.Metric, in the case this PR is addressing theinfluxserializer does not support+Inffloats.I considered having the serializer
return nil, nil, but decided against it because this would require users to check both the error and the buffer before writing the metric. Another option would be to return a sentinel error value that could be used to ignore, I think this may be a good method but I opted to not introduce any new types at this time.closes #5858
Required for all PRs: