-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Influxdb listener keep database #6256
Closed
morfien101
wants to merge
16
commits into
influxdata:master
from
morfien101:influxdb_listener_keep_database
Closed
Influxdb listener keep database #6256
morfien101
wants to merge
16
commits into
influxdata:master
from
morfien101:influxdb_listener_keep_database
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a comment to a function to explain what it should do.
Updated readme file to represent this. Updated the Sample config to include the configuration changes.
Refactored the code to use the internal.ContentEncoders. Refactored the block splitting for determing optimal message size for Kinesis Updated the read me to use content_encoding
…kinesis_compressed_metrics Keeping branch updated
…influxdb_listener_keep_database
Setting database tag if needed Adding test to look for the database tag if requested to keep it.
this has code from another branch it. Closing to submit a clean master branch. 😭 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR for Issue #6253
Added a toggle to keeping the database.
Added a default database tag name.
Added a test to see if the database tag is there when requested to keep it. (TestWriteHTTPKeepDatabase)
Put in the toml tags to make the plugin like most of the other plugins that have explicit toml tags in the main struct. I used the names from the configuration that we have currently for this.
Required for all PRs: