feat(parser/json): continue parsing JSON after invalid object in array, with an option of strict to enforce validity of all objects #6536

rawkode · 2019-10-17T09:56:37Z

closes #6532

Required for all PRs:

Signed CLA.
Associated README.md updated.
Has appropriate unit tests.

rawkode · 2019-10-17T09:56:57Z

Closes #6532

plugins/parsers/json/README.md

danielnelson · 2019-10-21T21:38:36Z

plugins/parsers/json/parser.go

@@ -73,7 +76,14 @@ func (p *Parser) parseArray(data []interface{}) ([]telegraf.Metric, error) {
 		case map[string]interface{}:
 			metrics, err := p.parseObject(v)
 			if err != nil {
-				return nil, err
+				log.Printf("E! [parsers.json] Invalid JSON object: %v", v)


Remove this log message since we are returning the error.

plugins/parsers/json/parser.go

plugins/parsers/json/parser_test.go

…y, with an option of strict to enforce validity of all objects

VitaliyBreslavskyi · 2020-01-15T13:40:28Z

Hi @rawkode,

Could it be that there is some error in this feature or description?

I'm getting weird error when trying to use example configuration for JSON:
telegraf_1 | 2020-01-15T13:28:05Z I! Starting Telegraf 1.13.0
telegraf_1 | 2020-01-15T13:28:05Z I! Using config file: /etc/telegraf/telegraf.conf
telegraf_1 | 2020-01-15T13:28:05Z E! [telegraf] Error running agent: Error parsing /etc/telegraf/telegraf.d/input_json.conf, line 37: field corresponding to `json_strict' is not defined in file.File

rawkode · 2020-01-15T13:42:24Z

@VitaliyBreslavskyi Can you open a new issue and provide your configuration file, please?

Thanks

VitaliyBreslavskyi · 2020-01-15T13:42:59Z

@VitaliyBreslavskyi Can you open a new issue and provide your configuration file, please?

Thanks

Sure, in progress...

danielnelson suggested changes Oct 21, 2019

View reviewed changes

danielnelson added this to the 1.13.0 milestone Oct 21, 2019

danielnelson added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Oct 21, 2019

feat(parser/json): continue parsing JSON after invalid object in arra…

8ef0a81

…y, with an option of strict to enforce validity of all objects

rawkode requested a review from danielnelson October 22, 2019 11:21

danielnelson approved these changes Oct 23, 2019

View reviewed changes

danielnelson merged commit a9a0d40 into influxdata:master Oct 23, 2019

rawkode deleted the feature/allow-continue-invalid-json-objects branch October 23, 2019 21:15

VitaliyBreslavskyi mentioned this pull request Jan 15, 2020

Error running agent: json_strict is not defined #6906

Closed

athoune pushed a commit to bearstech/telegraf that referenced this pull request Apr 17, 2020

Add strict mode to JSON parser (influxdata#6536)

4b7b536

idohalevi pushed a commit to idohalevi/telegraf that referenced this pull request Sep 29, 2020

Add strict mode to JSON parser (influxdata#6536)

b9c67be

arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023

Add strict mode to JSON parser (influxdata#6536)

6ac4a7d

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(parser/json): continue parsing JSON after invalid object in array, with an option of strict to enforce validity of all objects #6536

feat(parser/json): continue parsing JSON after invalid object in array, with an option of strict to enforce validity of all objects #6536

rawkode commented Oct 17, 2019 •

edited by danielnelson

Loading

rawkode commented Oct 17, 2019

danielnelson Oct 21, 2019

VitaliyBreslavskyi commented Jan 15, 2020

rawkode commented Jan 15, 2020

VitaliyBreslavskyi commented Jan 15, 2020

feat(parser/json): continue parsing JSON after invalid object in array, with an option of strict to enforce validity of all objects #6536

feat(parser/json): continue parsing JSON after invalid object in array, with an option of strict to enforce validity of all objects #6536

Conversation

rawkode commented Oct 17, 2019 • edited by danielnelson Loading

Required for all PRs:

rawkode commented Oct 17, 2019

danielnelson Oct 21, 2019

Choose a reason for hiding this comment

VitaliyBreslavskyi commented Jan 15, 2020

rawkode commented Jan 15, 2020

VitaliyBreslavskyi commented Jan 15, 2020

rawkode commented Oct 17, 2019 •

edited by danielnelson

Loading