Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure_iothub_consumer - Input plugin #7040

Closed
wants to merge 9 commits into from

Conversation

chrishayles
Copy link
Contributor

…crosoft fix.

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

To follow once code adjustments have been made following cert fix.

@chrishayles
Copy link
Contributor Author

chrishayles commented Feb 19, 2020

Known issues/required changes:

  • Include tests for plugins. [Telegraf plugin code] Complete
  • - More detailed README. [Telegraf plugin code] Complete
  • - PR required for iothub module to introduce "iotmodule" type. [iothub module code] Rolled iotmodule into iotdevice instead
  • - Move output plugin from "iotdevice" to "iotmodule." [Telegraf plugin code] n/a as above
  • - Move input plugin from "iotservice" to "iotmodule." [Telegraf plugin code] n/a as above
  • - Add other transport protocols to "iothub" module and create second pull request. [iothub module code]
  • - input plugin here needs to work with Telegraf parser and accumulator instead of current log output. [Telegraf plugin code] Complete
  • - Typo in the input plugin filename. Complete

@danielnelson
Copy link
Contributor

Can you also add some information about when this plugin would need to be used instead of #6928?

@chrishayles
Copy link
Contributor Author

@danielnelson Hey Daniel, forwarded on an email I sent to your colleagues last month. Lookout for something from [email protected].

Short version: the IoT Hubs has an "Event Hubs Compatible" endpoint, but that endpoint doesn't have anywhere near the functionality of establishing a device connection with the IoT Hub and won't make use of an edge setup.

Copy link
Contributor Author

@chrishayles chrishayles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Highlighting issues.

go.mod Outdated Show resolved Hide resolved
plugins/outputs/azure_iothub/iothub/common/tls.go Outdated Show resolved Hide resolved
@danielnelson danielnelson marked this pull request as draft April 16, 2020 19:18
@chrishayles chrishayles changed the title Added iothub plugins - input and output. Work still required after Mi… azure_iothub_consumer - Input plugin May 29, 2020
@chrishayles
Copy link
Contributor Author

Fixed dependency issue, removed iothub library codebase to reflect this. Cleaned up the metric creation.

@chrishayles chrishayles marked this pull request as ready for review May 29, 2020 22:43
@sjwang90 sjwang90 added the area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor label Jul 31, 2020
@sjwang90 sjwang90 added the area/iot New plugins or features relating to IoT monitoring label Oct 26, 2020
@sjwang90 sjwang90 added the plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins label Jan 22, 2021
@reimda reimda removed the request for review from danielnelson June 17, 2021 21:04
@srebhan
Copy link
Member

srebhan commented May 12, 2022

@chrishayles is this still a thing?

@srebhan srebhan self-assigned this May 12, 2022
@powersj powersj added the waiting for response waiting for response from contributor label May 12, 2022
@telegraf-tiger
Copy link
Contributor

Hello! I am closing this issue due to inactivity. I hope you were able to resolve your problem, if not please try posting this question in our Community Slack or Community Page. Thank you!

@telegraf-tiger telegraf-tiger bot closed this May 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/azure Azure plugins including eventhub_consumer, azure_storage_queue, azure_monitor area/iot New plugins or features relating to IoT monitoring new plugin plugin/input 1. Request for new input plugins 2. Issues/PRs that are related to input plugins waiting for response waiting for response from contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants