Add processor to look up service name by port #7540
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
danielnelson
suggested changes
May 19, 2020
| var err error | ||
| port, err = strconv.Atoi(portProtoSlice[0]) | ||
| if err != nil { | ||
| // Can't convert port to string |
There was a problem hiding this comment.
Log this as an error.
There was a problem hiding this comment.
I added logging here and in most other cases in Apply. It now logs an error if they provide the port tag but it's empty, or if it's not empty but won't parse as an int, or if they supply a protocol that isn't in the services file (meaning not tcp or udp). It logs a debug message if the port/protocol isn't in the services file.
danielnelson
approved these changes
May 20, 2020
jaecktec
pushed a commit
to jaecktec/telegraf
that referenced
this pull request
Jun 8, 2020
rhajek
pushed a commit
to bonitoo-io/telegraf
that referenced
this pull request
Jul 13, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #7244