Expand shim for processor and outputs. #7677
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reimda
reviewed
Jun 24, 2020
plugins/common/shim/config.go
Outdated
| return fmt.Errorf("Failed to add Processor: %w", err) | ||
| } | ||
| } else if conf.Output != nil { | ||
| if err = s.AddOutput(conf.Output); err != nil { |
There was a problem hiding this comment.
Does this let people have multiple inputs, processors, and outputs in the same shim? I guess I expected one plugin of any type per shim process.
There was a problem hiding this comment.
yeah, you can only have one.
|
rebased master to resolve conflicts... and that might have screwed up this branch... |
3 tasks
|
Merging this PR will fix some data races reported in #7729 too. |
danielnelson
reviewed
Jul 2, 2020
danielnelson
approved these changes
Jul 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Expands execd shim support for processors and outputs.
Execd lets you write custom input, processor, and output plugins in any language. The execd shim lets you run plugins written in Go without changing the structure, regardless of whether they're run as internal plugins compiled into Telegraf, or external plugins compiled as a separate binary and run through execd.