Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for kubernetes jobs #7790

Closed
wants to merge 1 commit into from
Closed

Add support for kubernetes jobs #7790

wants to merge 1 commit into from

Conversation

carlosv-ukg
Copy link

@carlosv-ukg carlosv-ukg commented Jul 6, 2020 •
edited
Loading

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Closes #7779

@carlosv-ukg carlosv-ukg marked this pull request as draft July 6, 2020 19:47
@carlosv-ukg carlosv-ukg force-pushed the kubernetes_job branch 2 times, most recently from 0bcb8ea to d863dea Compare July 11, 2020 00:11
@carlosv-ukg carlosv-ukg marked this pull request as ready for review July 11, 2020 00:12
@carlosv-ukg carlosv-ukg force-pushed the kubernetes_job branch 3 times, most recently from d863dea to 7a16e9d Compare July 11, 2020 00:31
@sspaink
Copy link
Contributor

sspaink commented Apr 1, 2021

@carlosv-ukg thank you for this pr, with this recent pr #8937 the project has moved to use github.com/kubernetes/client-go in the kube-inventory plugin. Would you be able to migrate this pull request to use this new library?

@carlosv-ukg
Copy link
Author

@sspaink I took a look at the repo and it wasn't obvious to me how I could port these changes over to github.com/kubernetes/client-go. Do you have a PR when you brought over the code-base?

@sspaink
Copy link
Contributor

sspaink commented Apr 1, 2021

This is the pull request that migrated telegraf to github.com/kubernetes/client-go: https://github.com/influxdata/telegraf/pull/8937

I think this is the function you need to get the job list: https://github.com/kubernetes/client-go/blob/master/kubernetes/typed/batch/v1/job.go#L86

Hopefully that helps?

@carlosv-ukg
Copy link
Author

gotcha thanks! that's helpful. I'll see what I can do to port over the change 👍

@carlosv-ukg
Copy link
Author

Closing now that the project has moved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
area/k8s
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for kubernetes jobs
3 participants
@carlosv-ukg @sspaink @sjwang90