Fix for opentsdb output-plugin for NaN and Inf in float64 value #7908
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JSON does not support values NaN and Inf
ssoroka
reviewed
Jul 28, 2020
| case int64: | ||
| case uint64: | ||
| case float64: | ||
| // JSON does not support these special values | ||
| if math.IsNaN(fv) || math.IsInf(fv, 0) { | ||
| continue |
There was a problem hiding this comment.
Looks like elsewhere these are serialized as null. should we be doing that instead?
There was a problem hiding this comment.
Looks like elsewhere these are serialized as
null. should we be doing that instead?
I do not think so. I dont found any of. So. Here we have a type checking, its logical to add checking of float64 for NaN or Inf. And we have errors for NaN from 1.14 version =)
ssoroka
approved these changes
Aug 6, 2020
ssoroka
pushed a commit
that referenced
this pull request
Aug 29, 2020
idohalevi
pushed a commit
to idohalevi/telegraf
that referenced
this pull request
Sep 29, 2020
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
When in prometheus metrics we have a value with NaN or Inf, Telegraf cannot to send metrics in TSDB and write the error in stdout:
I fixed this error like in json serializer: https://github.com/influxdata/telegraf/blob/master/plugins/serializers/json/json.go#L61