Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Dynatrace Output: change handling of monotonic counters #8159

Merged
merged 59 commits into from
Sep 30, 2020
Merged

Dynatrace Output: change handling of monotonic counters #8159

merged 59 commits into from
Sep 30, 2020

Conversation

thschue
Copy link
Contributor

@thschue thschue commented Sep 21, 2020

Required for all PRs:

  • Signed CLA.
  • Associated README.md updated.
  • Has appropriate unit tests.

Thomas Schuetz and others added 30 commits July 2, 2020 11:32
added dynatrace client install instructions
b5f2608
fixed some minor issues
d2c3d57
added idea to gitignore
72dd44e
@wolfgangB33r
changed to DT normalized metric and dimension keys
f49ac2a
@wolfgangB33r
changed to DT normalized metric and dimension keys
62c6054
@wolfgangB33r
changed escaping of values to strconv.Quote
34d5f56
@thschue
Merge pull request #1 from dynatrace-oss-contrib/include-dt-plugin
8091b28 
Add Dynatrace Plugin
added oneagent support
de0b09f
adapted handling for oneagent
9c4f3d7
removed debug output
6ae8014
@thschue
Merge pull request #2 from dynatrace-oss-contrib/add-oneagent
3aa5d94 
Add oneagent handling
fixed normalization for fields, if they start with a digit
02f560c
Merge branch 'master' of github.com:influxdata/telegraf
795e3c5
fixed normalization
fb56fcf
changed package name
0e6a347
added readme information about direct OneAgent ingest endpoint
fc95083
@wolfgangB33r
added a metric name prefix setting
5087a01
Merge branch 'master' of github.com:influxdata/telegraf
c4284f7
fmtted file
9e7dccf
changed doc
91e26d9
@thschue @ssoroka
Update plugins/outputs/dynatrace/dynatrace.go
b783f3a 
Co-authored-by: Steven Soroka <[email protected]>
@thschue @ssoroka
Apply suggestions from code review
38a05fd 
Co-authored-by: Steven Soroka <[email protected]>
added requested changes
a273e62
changed log output
de2728f
changed tls configuration
72b0bc0
adapted tests
f75f254
fmtted file
72c2418
fixed tests
869cda4
@wolfgangB33r
fixed tag order and added encoding checks in all tests
9f16099
@wolfgangB33r
changed formatting
2167b54
thschue and others added 18 commits August 17, 2020 09:56
ssoroka
ssoroka approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@ssoroka ssoroka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems reasonable. Confirming names are now allowed to have hyphens?

plugins/outputs/dynatrace/README.md Outdated Show resolved Hide resolved
@thschue
Copy link
Contributor Author

thschue commented Sep 22, 2020

seems reasonable. Confirming names are now allowed to have hyphens?

Yes, they are.

@thschue thschue requested a review from ssoroka September 24, 2020 11:23
@ssoroka ssoroka merged commit f2a831c into influxdata:master Sep 30, 2020
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
@thschue
Dynatrace Output: change handling of monotonic counters (influxdata#8159
cdd03bb 
)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wolfgangB33r wolfgangB33r wolfgangB33r left review comments

@ssoroka ssoroka ssoroka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@thschue @ssoroka @wolfgangB33r @mikopp