Fixed minor issue in datacenter name lookup code #8505
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
srebhan
approved these changes
Dec 4, 2020
srebhan
added
the
ready for final review
ssoroka
approved these changes
Dec 4, 2020
| @@ -437,7 +437,7 @@ func (e *Endpoint) discover(ctx context.Context) error { | |||
| } | |||
|
|
|||
| // Fill in datacenter names where available (no need to do it for Datacenters) | |||
| if res.name != "Datacenter" { | |||
| if res.name != "datacenter" { | |||
There was a problem hiding this comment.
Is there any value in making this comparison case insensitive, or is it always capitalized?
There was a problem hiding this comment.
It’s always capitalized. It’s just a key used internally in the code.
|
@prydin We'd like to merge this for the 1.17 release tomorrow. Could you respond to Steven's question about case sensitivity? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
Due to a spelling error in an if-statement, the code to resolve names of datacenters was called even when the name was known. This also caused a somewhat misleading debug message to be shown.