Added Glob pattern matching for "Windows Services" plugin #8575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ssoroka
reviewed
Dec 16, 2020
ssoroka
reviewed
Dec 16, 2020
ssoroka
reviewed
Dec 16, 2020
ssoroka
approved these changes
Dec 16, 2020
ssoroka
pushed a commit
that referenced
this pull request
Dec 16, 2020
* Allow glob patterns in config * Update README * Move creating filter to init * Need to explictly call init Co-authored-by: Bas <[email protected]> (cherry picked from commit b858eb9)
3 tasks
arstercz
pushed a commit
to arstercz/telegraf
that referenced
this pull request
Mar 5, 2023
…#8575) * Allow glob patterns in config * Update README * Move creating filter to init * Need to explictly call init Co-authored-by: Bas <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Required for all PRs:
This pull request addresses the issue #3673
Updated the "Windows Services" plugin to allow glob patterns in the input config for including services.
I based the changes on the Docker plugin which also allows glob pattern matching.
Tested the changes locally and uploaded some information: