-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump prometheus dependency to v2.21.0 #8795
Bump prometheus dependency to v2.21.0 #8795
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
ac613e8
to
32cbc18
Compare
Ok so unfortunately this makes the tests to fail because of an assertion in https://github.com/protocolbuffers/protobuf-go/blob/v1.24.0/internal/impl/legacy_message.go#L136
|
@pmalek-sumo Thank you for this pr, I've updated the Kubernetes go client in this pr #8937 so the failure in the tests you were getting should be resolvable now. |
32cbc18
to
cc6e116
Compare
cc6e116
to
a5671fd
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
Thanks @sspaink ! It seems the patch is now clean to apply. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
* Bump prometheus dependency to v2.21.0 * Make golangci-lint happy
Bump Prometeus dependency to
v2.21.0
.In order to achieve this the following
go get
was performed:The reason for this is that Prometheus doesn't follow Go module semver conventions (its module should have a
/v2
suffix but there's no intention in doing this - prometheus/prometheus#7991 (comment)).The remaining changes are coming from a change in PB files from
github.com/prometheus/prometheus/prompb
from 1 to 2 via PRMotivation
Apart from being up to date the motivation it will allow other projects to use telegraf package's e.g.
github.com/influxdata/telegraf/agent
.The use case where I hit this was when I was trying to import
github.com/influxdata/telegraf/agent
from within https://github.com/open-telemetry/opentelemetry-collector-contrib which gave me the following errors:Please note the
v2.5.0+incompatible
that is required as of now (which doesn't understand Go modules hence most of the problems listed above).