Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace github.com/kubernetes import with k8s.io and update protobuf to v1.5.1 #9039

Merged
merged 4 commits into from
Mar 24, 2021

Conversation

sspaink
Copy link
Contributor

@sspaink sspaink commented Mar 23, 2021

Closes #9021

Fixing this import path to match the one used everywhere else removes the "duplicate proto" message.

Also updated protobuf library to the latest change, this didn't fix the issue but seemed like a good change to keep.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

@telegraf-tiger telegraf-tiger bot added the fix pr to fix corresponding bug label Mar 23, 2021
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sspaink sspaink changed the title Change duplicate kubernetes import and update protobuf to v1.5.1 Replace github.com/kubernetes import with k8s.io and update protobuf to v1.5.1 Mar 24, 2021
@sspaink sspaink merged commit 29ac779 into influxdata:master Mar 24, 2021
jblesener pushed a commit to jblesener/telegraf that referenced this pull request Apr 18, 2021
…luxdata#9039)

* Change import and update protobuf

* fix check-deps

* go mod tidy

* keep imports consistent
reimda pushed a commit that referenced this pull request May 20, 2021
* Change import and update protobuf

* fix check-deps

* go mod tidy

* keep imports consistent

(cherry picked from commit 29ac779)
arstercz pushed a commit to arstercz/telegraf that referenced this pull request Mar 5, 2023
…luxdata#9039)

* Change import and update protobuf

* fix check-deps

* go mod tidy

* keep imports consistent

(cherry picked from commit 29ac779)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fix pr to fix corresponding bug
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fix "duplicate proto type registered"
3 participants