-
Notifications
You must be signed in to change notification settings - Fork 5.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace github.com/kubernetes import with k8s.io and update protobuf to v1.5.1 #9039
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤝 ✅ CLA has been signed. Thank you!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like new artifacts were built from this PR. Get them here!
Artifact URLs
…luxdata#9039) * Change import and update protobuf * fix check-deps * go mod tidy * keep imports consistent
* Change import and update protobuf * fix check-deps * go mod tidy * keep imports consistent (cherry picked from commit 29ac779)
…luxdata#9039) * Change import and update protobuf * fix check-deps * go mod tidy * keep imports consistent (cherry picked from commit 29ac779)
Closes #9021
Fixing this import path to match the one used everywhere else removes the "duplicate proto" message.
Also updated protobuf library to the latest change, this didn't fix the issue but seemed like a good change to keep.