Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Glob / Wildcard support to Cloudwatch input for 'Dimensions' configuration #9136

Merged
merged 4 commits into from
Apr 20, 2021
Merged

Add Glob / Wildcard support to Cloudwatch input for 'Dimensions' configuration #9136

merged 4 commits into from
Apr 20, 2021

Conversation

ivorybilled
Copy link
Contributor

I believe this will resolve #4046

@telegraf-tiger telegraf-tiger bot added the feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin label Apr 15, 2021
telegraf-tiger[bot]
telegraf-tiger bot approved these changes Apr 15, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🤝 ✅ CLA has been signed. Thank you!

telegraf-tiger[bot]
telegraf-tiger bot reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

telegraf-tiger[bot]
telegraf-tiger bot reviewed Apr 15, 2021
View reviewed changes
Copy link
Contributor

@telegraf-tiger telegraf-tiger bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like new artifacts were built from this PR. Get them here!

Artifact URLs

srebhan
srebhan reviewed Apr 19, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems reasonable to me. Some small comments in the code.

@srebhan srebhan self-assigned this Apr 19, 2021
@ivorybilled
Copy link
Contributor Author

!retry-checks

srebhan
srebhan approved these changes Apr 20, 2021
View reviewed changes
Copy link
Member

@srebhan srebhan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@srebhan srebhan added the ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review. label Apr 20, 2021
@sspaink sspaink merged commit e29bca7 into master Apr 20, 2021
@sspaink sspaink deleted the cloudwatchDimensionsGlobSupport branch April 20, 2021 21:30
@liorfranko liorfranko mentioned this pull request May 31, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@telegraf-tiger telegraf-tiger[bot] telegraf-tiger[bot] approved these changes

@sspaink sspaink sspaink approved these changes

@srebhan srebhan srebhan approved these changes

Assignees

@srebhan srebhan

Labels
feat Improvement on an existing feature such as adding a new setting/mode to an existing plugin ready for final review This pull request has been reviewed and/or tested by multiple users and is ready for a final review.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Input: CloudWatch - Partial Wildcard or Regexp support?
3 participants
@ivorybilled @sspaink @srebhan